add backoff and reliability #172
Conversation
crates/http-sink/src/main.rs
Outdated
| config: &HttpConfig, | ||
| item: Result<Record, ErrorCode>, | ||
| ) -> Result<()> { | ||
| let str = String::from_utf8(item?.as_ref().to_vec())?; |
There was a problem hiding this comment.
is this need to be string? why not binary
There was a problem hiding this comment.
Yeah! It should be, it was like it already, but I changed to use bytes instead.
crates/http-sink/src/main.rs
Outdated
| "Waiting {} before next attempting to db", | ||
| humantime::format_duration(wait) | ||
| ); | ||
| async_std::task::sleep(wait).await; |
There was a problem hiding this comment.
Do I need add fluvio_future? is it worth?
I think that we should have a sleep public in fluvio-connector-common. wdyt?
There was a problem hiding this comment.
this is to keep dep minimize.
There was a problem hiding this comment.
ok, I changed to use sleep from fluvio_future
crates/http-sink/src/main.rs
Outdated
| async_std::task::sleep(wait).await; | ||
| Ok(()) | ||
| } else { | ||
| let err_msg = "Max retry on SQL Execution, shutting down"; |
| @@ -3,7 +3,7 @@ name = "http-sink" | |||
| group = "infinyon" | |||
| version = "0.2.11" | |||
| apiVersion = "0.1.0" | |||
| fluvio = "0.12.0" | |||
| fluvio = "0.13.0" | |||
There was a problem hiding this comment.
will this work with previous version of fluvio? Is there reason to bump this up?
There was a problem hiding this comment.
I think that this is only metadata of which fluvio version this connector is using.
Should work with previous fluvio version too.
No description provided.