Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for rust 1.48 #3356

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

rockstar
Copy link
Contributor

Rust 1.48 was released a few days ago. This patch adds the fixes that
will get flux passing in CI again. The following things needed
addressed:

Rust 1.48 was released a few days ago. This patch adds the fixes that
will get flux passing in CI again. The following things needed
addressed:

  - There is a new lint introduced that checks for `push_str` on a
single char `str`, and recommends using `push` instead.
  - There is an open issue with `sccache` and rust 1.48. As a result,
`sccache` is desabled for now. See mozilla/sccache#887
@codecov-io
Copy link

Codecov Report

Merging #3356 (6499c83) into master (9c3cf77) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3356      +/-   ##
==========================================
+ Coverage   47.34%   47.36%   +0.01%     
==========================================
  Files         350      350              
  Lines       35304    35304              
==========================================
+ Hits        16715    16720       +5     
+ Misses      16063    16058       -5     
  Partials     2526     2526              
Impacted Files Coverage Δ
libflux/go/libflux/parser.go 67.64% <0.00%> (+1.47%) ⬆️
libflux/go/libflux/analyze.go 54.05% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3cf77...6499c83. Read the comment docs.

@rockstar rockstar requested review from a team and adrian-thurston and removed request for a team November 24, 2020 06:12
@drahnr
Copy link

drahnr commented Nov 24, 2020

I'd recommend using either https://github.com/paritytech/sccache or at least the latest master of mozilla.

Copy link

@wolffcm wolffcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me... I guess builds will be slow until the bug is addressed. Should we have an issue to reenable it? I don't want us to forget.

@rockstar
Copy link
Contributor Author

I'd recommend using either https://github.com/paritytech/sccache or at least the latest master of mozilla.

I'm not sure I'm comfortable running from master or using an unofficial fork, particularly for something that essentially wraps out compiler. We'll keep an eye on it, and if anything changes, we'll re-consider.

Should we have an issue to reenable it? I don't want us to forget.

There is an XXX comment, but I also filed #3357 to track it.

@rockstar rockstar merged commit 0d9d585 into influxdata:master Nov 24, 2020
@rockstar rockstar deleted the chore/rust-1.48-support branch November 24, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants