URL-Encode Password in influxdb/client #1367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
The client code is getting heavily reworked right now, so I am not sure if it is worth merging. @corylanou ? |
|
@otoolep the entire client is getting re-worked from the ground up. 100% re-write so there will be nothing to merge. |
|
OK. Thanks @MakaHost -- I'm going to close this, since the code is being entirely re-written, that should be soon, so keep an eye out for similar issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey
Password with special characters had to be escaped manually in order to work before. Because that is something the user shouldn't have to do, I added the encoding of the password.
In order to not brake other programs that fixed this themselves (influx-cli for example) I added an additional url.QueryUnescape before escaping it.
Was fixed for example in Dieterbe/influx-cli#15