Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow new tags in schema again #26108

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Conversation

mgattozzi
Copy link
Contributor

This commit restores the old behavior we had where new tags can be added to a schema. To do this we made tags nullable and brings us in line with our other products. These changes were made in this PR:

influxdata/influxdb3_core#41.

Changes to accomplish this new behavior were:

  • Queries now do not return an empty string for null tags instead they are returned as null, or in many formats not at all.
  • References to v1 for parsing and validating lines were removed as we only have one path for doing so these days shared amongst all the write_lp endpoints.
  • We fixed failing tests that expected us to not be able to have new tags or depended on that functionality indirectly
  • Tests had their snapshot files updated to reflect that tags are nullable by default
  • Behavior for making a schema and checking whether a column can be null were updated in a separate repo and integrated here
  • The series_key is updated whenever we get a new tag added to the schema
  • New tests were added to show that you can add a new tag and that the series key is updated as part of that

With the above changes we can now allow tags to be added again by users like they would expect, especially with v1 and v2 apis and Telegraf plugins.

Closes #25932
Closes #26065

This commit restores the old behavior we had where new tags can be added
to a schema. To do this we made tags nullable and brings us in line with
our other products. These changes were made in this PR:

influxdata/influxdb3_core#41.

Changes to accomplish this new behavior were:

- Queries now do not return an empty string for null tags instead they
  are returned as null, or in many formats not at all.
- References to v1 for parsing and validating lines were removed as we
  only have one path for doing so these days shared amongst all the
  write_lp endpoints.
- We fixed failing tests that expected us to not be able to have new
  tags or depended on that functionality indirectly
- Tests had their snapshot files updated to reflect that tags are
  nullable by default
- Behavior for making a schema and checking whether a column can be null
  were updated in a separate repo and integrated here
- The series_key is updated whenever we get a new tag added to the
  schema
- New tests were added to show that you can add a new tag and that the
  series key is updated as part of that

With the above changes we can now allow tags to be added again by users
like they would expect, especially with v1 and v2 apis and Telegraf
plugins.
@mgattozzi mgattozzi requested review from pauldix and hiltontj March 6, 2025 16:39
@mgattozzi mgattozzi added the v3 label Mar 6, 2025
@mgattozzi
Copy link
Contributor Author

Corresponding Enterprise PR -> https://github.com/influxdata/influxdb_pro/pull/534

Pretty much the same thing as this, but with updated Enterprise tests. I'll sync these changes into Enterprise once this is approved and get that PR moving along.

Copy link
Member

@pauldix pauldix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for working through all the back and forth on it

@mgattozzi mgattozzi merged commit 329ef2f into main Mar 6, 2025
12 checks passed
@mgattozzi mgattozzi deleted the mgattozzi/let-there-be-tags branch March 6, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants