-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.stackdriver): Ensure quota is charged to configured project #16583
base: master
Are you sure you want to change the base?
feat(outputs.stackdriver): Ensure quota is charged to configured project #16583
Conversation
- Updated Stackdriver output plugin to use the `project` field from the Telegraf configuration for quota attribution via `option.WithQuotaProject(s.Project)`. - Ensures metric ingest quota is billed to the correct destination project instead of the scoping project's service account. - Preserves existing behavior while improving clarity and correctness in quota handling.
Make QuotaProject optional.
Remove comments that may be causing circle-ci tests to fail
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crflanigan! Just a single comment...
## Quota Project | ||
## Specifies the Google Cloud project that should be charged for metric ingestion quota. | ||
## If omitted, the quota is charged to the project associated with the service account. | ||
## This is useful when sending metrics to multiple projects using a single service account, | ||
## ensuring that the target projects are billed instead of the service account's project. | ||
## | ||
## The caller must have the `serviceusage.services.use` permission on the specified quota project. | ||
# quota_project = "billing-project" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default is empty isn't it? So how about shortening this to
## Quota Project | |
## Specifies the Google Cloud project that should be charged for metric ingestion quota. | |
## If omitted, the quota is charged to the project associated with the service account. | |
## This is useful when sending metrics to multiple projects using a single service account, | |
## ensuring that the target projects are billed instead of the service account's project. | |
## | |
## The caller must have the `serviceusage.services.use` permission on the specified quota project. | |
# quota_project = "billing-project" | |
## Quota Project to charge for metric ingestion quota | |
## If omitted, the quota is charged to the project associated with the service account. | |
## The caller must have the `serviceusage.services.use` permission on the specified quota project. | |
# quota_project = "" | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! So I guess the only concern I would have is that we removed the explanation as to what this would be used for, sending to multiple projects using a single SA while pointing the quota at the destination project instead of the SA project.
How about this?
## Quota Project
## Specifies the Google Cloud project that should be billed for metric ingestion.
## If omitted, the quota is charged to the service account’s default project.
## This is useful when sending metrics to multiple projects using a single service account.
## The caller must have the `serviceusage.services.use` permission on the specified project.
# quota_project = ""
project
field from the Telegraf configuration for quota attribution viaoption.WithQuotaProject(s.Project)
.Summary
Checklist
Related issues
resolves #16584