-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): remove notebook's unused buttons #7008
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source branch should be master
; the OSS-2.7
branch is used for releases.
Removing the button should depend on the CLOUD
property, because the source is shared between CLOUD and OSS. You can use something like:
Line 146 in 5cfee32
{CLOUD ? ( |
Hi @bednar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me. Thank you for doing this. I have one correction on an import and one suggestion about how to simplify the menuItems
array.
Hi @wdoconnell. Thank for the review |
Closes #6931
Remove two unused buttons in the Notebook screen for OSS:
Before:


After:
Checklist
Authors and Reviewer(s), please verify the following: