Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update retention rule for CLOUD and OSS #7016

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

NguyenHoangSon96
Copy link

@NguyenHoangSon96 NguyenHoangSon96 commented Feb 25, 2025

Closes #1607

Fix the bug when updating the retention period of buckets:

  • Before fix: set a retention period, eg. 1 hour, then change to never -> the retention period is still 1 hour
  • After fix: set a retention period, eg. 1 hour, then change to never -> the retention period changes to never

The recorded screen is the result when update in OSS:

Screen.Recording.2025-02-25.at.15.18.00.mov

The image is the result when update in CLOUD:

Note: I have to mock the variable CLOUD because I don't know how to run the CLOUD in my local. In the captured screen the retentionRules in the payload is not exists when send to the backend like ui team suggested
Screenshot 2025-02-25 at 15 14 05

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this: I have one suggestion about how to convert this to a ternary. Otherwise, it looks good to me. Let me confer with the folks working on the OSS backend to ensure the OSS-specific change is correct.

@NguyenHoangSon96 NguyenHoangSon96 force-pushed the fix/update-retention-policy branch from 08aeb3f to 5cd6dca Compare March 6, 2025 09:54
@NguyenHoangSon96
Copy link
Author

Hi @wdoconnell. Thank for the review
I fixed all things you mentioned
Please check again

@philjb philjb requested a review from wdoconnell March 6, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing retention to "forever" in UI does not work
3 participants