Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace onboarding wizard flags with selector #7019

Merged
merged 10 commits into from
Mar 6, 2025

Conversation

mavarius
Copy link
Collaborator

@mavarius mavarius commented Feb 28, 2025

This PR replaces the use of the ioxOnboarding feature flag with the isOrgIox selector. It refactors all the components from class to functional components using the useSelector hook.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@mavarius mavarius requested review from a team as code owners February 28, 2025 22:56
@mavarius mavarius changed the title Chore(ui): Replace onboarding wizard flags with selector Chore: Replace onboarding wizard flags with selector Feb 28, 2025
@mavarius mavarius changed the title Chore: Replace onboarding wizard flags with selector fix: Replace onboarding wizard flags with selector Feb 28, 2025
Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mavarius Looks good to rebase and merge in - I gave this a test with IOx off and on in local dev, and it looks great. Thank you for refactoring to functional components as needed!

@mavarius mavarius force-pushed the chore/replace-onboarding-flags-with-selector branch from 6790306 to c1a3408 Compare March 5, 2025 22:47
@mavarius mavarius added this pull request to the merge queue Mar 6, 2025
Merged via the queue into master with commit 3e421ec Mar 6, 2025
6 checks passed
@mavarius mavarius deleted the chore/replace-onboarding-flags-with-selector branch March 6, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants