Merge release liveness #401
Open
+88
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, customizing the dsnname would throw a validation error
and prevent any processing of the databaseclaim. This allows the
customization but ensures the normalized fields are always
populated.
A bug in the conversion webhook added dbproxy mutating labels
when only dsnexec was requested. This would cause issues if
the pod could not handle dbproxy listening on port 5432.
Make the probes optional as a fallback that the liveness probe
failure issues are not resolved.
dsnexec does not use the standard mount volumes of dbproxy. So
it can't use probes pointing to those mount volumes. Removed
the liveness probe and setup the readiness probe to point
to DBPROXY_CREDENTIAL env variable.
* release/v1.10.x: DEVOPS-30642 disable liveness probes (#395) DEVOPS-30870: fix password rotation logic (#393) DEVOPS-30046 optional sidecar probes (#384) DEVOPS-30046 DEVOPS-30239 dsnexec conversion injects dbproxy (#381) update start-pgbouncer to exit after 60seconds (#379) PTEUDO-2142 remove validation of DSNName (#370) update CI pipeline for gitflow branch names
bfabricio
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge release branch into main