Add error if a read is attempted when no primary key (id) is set (#110)

* Add error if a read is attempted when no primary key (id) is set * Regen protos with upstream changes
infobloxopen · Aug 7, 2018 · f2e770d · f2e770d
1 parent f205804
commit f2e770d
Show file tree

Hide file tree

Showing 5 changed files with 41 additions and 0 deletions.
diff --git a/example/feature_demo/demo_multi_file.pb.gorm.go b/example/feature_demo/demo_multi_file.pb.gorm.go
diff --git a/example/feature_demo/demo_service.pb.gorm.go b/example/feature_demo/demo_service.pb.gorm.go
diff --git a/example/feature_demo/demo_types.pb.gorm.go b/example/feature_demo/demo_types.pb.gorm.go
diff --git a/example/user/user.pb.gorm.go b/example/user/user.pb.gorm.go
diff --git a/plugin/handlergen.go b/plugin/handlergen.go
@@ -104,6 +104,14 @@ func (p *OrmPlugin) generateReadHandler(message *generator.Descriptor) {
 	p.P(`if err != nil {`)
 	p.P(`return nil, err`)
 	p.P(`}`)
+	k, f := p.findPrimaryKey(ormable)
+	if strings.Contains(f.Type, "*") {
+		p.P(`if ormParams.`, k, ` == nil || *ormParams.`, k, ` == `, p.guessZeroValue(f.Type), ` {`)
+	} else {
+		p.P(`if ormParams.`, k, ` == `, p.guessZeroValue(f.Type), ` {`)
+	}
+	p.P(`return nil, errors.New("Read requires a non-zero primary key")`)
+	p.P(`}`)
 
 	p.sortOrderedHasMany(message)
 	p.P(`ormResponse := `, ormable.Name, `{}`)