Remove a logical test that is always true #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorrabot
force-pushed
the
master
branch
2 times, most recently
from
6cf8535 to
57fe1a6
Compare
gorrabot
force-pushed
the
master
branch
3 times, most recently
from
e3b26f9 to
f56dfca
Compare
gorrabot
force-pushed
the
master
branch
2 times, most recently
from
b43af42 to
a4a8989
Compare
gorrabot
force-pushed
the
master
branch
2 times, most recently
from
f8bb1df to
b264b2b
Compare
gorrabot
force-pushed
the
master
branch
2 times, most recently
from
7ae84b5 to
a7c8133
Compare
gorrabot
force-pushed
the
master
branch
2 times, most recently
from
4acca08 to
f6abaab
Compare
gorrabot
force-pushed
the
master
branch
2 times, most recently
from
81e546e to
9e80695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file: get_exploits.py, method: get_exploits, a logical expression uses the identity operator. A new object is created inside the identity check operation and then used for matching identity. Since this is a distinct, new object, it will not have identity an match with anything else. As a result, the identity check will have a logical short circuit and the program may have unintended behavior. I suggested that the logical operation should be reviewed for correctness.