-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic support for an openstack cloud provider. #332
Conversation
Nice, thanks Chris! I'll take a look at this when I get a chance. If someone gets to it before me, please feel free to merge it in after reviewing. |
end | ||
|
||
def private_ip_address | ||
addresses["vmnet"][0]["addr"] rescue nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead of hardcoding "vmnet" as network name you could use:
networks.first.addresses.first
(and delegate :networks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was something of a mistake - now fixed.
The problem was that the fog-side methods like "addresses" an "private_ip_address", etc will sometimes fail when the instances is just starting up. The important part of the above code is really the "rescue nil" part. I have pushed some code that works without any network hardcoding, and I may seek to get the underlying problems fixed in fog.
Changed the default to actually wait for ssh ports.
The NFS server will perform a reverse DNS query on any clients that try to connect. Only clients whose reverse DNS response matches this domain are allowed to connect.
Make the DNS search domain configurable at the cloud layer.
…rs to respect both cloud defined and compute defined security groups.
Patch c72a46 above should resolve issue #336. |
gem 'fog', "~> 1.2" | ||
gem 'excon', "~> 0.21.0" # v0.22 breaks EC2 calls | ||
gem 'fog', "~> 1.19" | ||
gem 'excon', "~> 0.31.0" # v0.22 breaks EC2 calls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment no longer valid
… of cloud.security group
:Fixed an unintende
Factor out cloud-specific security group code
Static cloud
display floating IP's, also bump excon
No description provided.