Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce provider traits for HasRuntime #74

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

soareschen
Copy link
Collaborator

Description

  • The runtime consumer traits are split into HasRuntimeType and HasRuntime.
  • Introduce the corresponding runtime provider traits ProvideRuntimeType and ProvideRuntime.
  • HasRuntime::runtime_error(e) is replaced by CanRaiseError<Runtime::Error> for handling runtime errors.
  • ProvideTokioRuntimeType component offers implementing HasRuntimeType::Runtime with TokioRuntimeContext.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@soareschen soareschen merged commit 61567de into main Dec 18, 2023
10 checks passed
@soareschen soareschen deleted the soares/runtime-provider-trait branch December 18, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant