Detect import paths that only differ in capitalization #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
changed the title
konnov
changed the title
bugarela
reviewed
Dec 7, 2023
quint/cli-tests.md
Outdated
|
|
||
| <!-- !test exit 1 --> | ||
| <!-- !test check parse testFixture/_1060case.qnt - parse case sensitive filenames --> | ||
| quint parse testFixture/_1060case.qnt |
There was a problem hiding this comment.
Should we also check if the error matches the expected? I think this test would pass even before your change.
There was a problem hiding this comment.
I also wanted to do that. But it's a bit hard to do, since the quint parse outputs absolute paths.
There was a problem hiding this comment.
I've fixed this test by moving it to io-cli-tests.md and comparing the outputs.
Co-authored-by: Thomas Pani <[email protected]>
Co-authored-by: Gabriela Moreira <[email protected]>
|
I think I have addressed all of the comments. Please have a look |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1194. This PR adds detection of filenames that use different capitalization. If this is the case, the parser flags an error. We have been discussing the option of storing hashes instead of normalized filenames, but this seems to be an overkill at the moment.
CHANGELOG.mdfor any new functionality