Introduce a new run operator expect
#1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konnov
requested review from
shonfeder,
bugarela,
thpani,
hvanz and
josef-widder
bugarela
reviewed
Dec 12, 2023
Comment on lines
1346
to
1349
| // rollback to the previous state in any case | ||
| this.recoverVars(savedVarsAfterAction) | ||
| this.recoverNextVars(savedNextVarsAfterAction) | ||
| this.resetTrace(just(rv.mkList(savedTraceAfterAction))) |
There was a problem hiding this comment.
Do we really need the rollback if the effect is already preventing updates inside the expect argument? I found the "rollback" explanation in the documentation confusing.
There was a problem hiding this comment.
I'm also not clear on why a rollback is needed.
There was a problem hiding this comment.
I have added clarifying comments about why we have to do that in the simulator
I think this should say |
shonfeder
reviewed
Dec 12, 2023
Yeah, I keep typing |
Co-authored-by: Shon Feder <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1252. Following the discussion raised by @hvanz, I have implemented the operator
A.expect(P)with the following semantics:A:A's result isfalse, emit a runtime error.A's result istrue:P:Pevaluates tofalse, emit a runtime error (similar toassert).Pevaluates totrue, rollback to the previous state and returntrue.Its semantics looks a bit complex, but this is basically what we want, if we do not want to have an extra stuttering step that calls
assert(P).Here are the examples from the unit tests:
CHANGELOG.mdfor any new functionality