Address go vet complaints (#16)

connector/client/client.go

@@ -112,7 +112,7 @@ func (client *ConnectorClient) getToken() (string, error) {
 	a := &schema.AuthResponse{}
 	err = json.NewDecoder(resp.Body).Decode(a)
 	if err != nil {
-		return "", fmt.Errorf("Invalid activity to send", err)
+		return "", fmt.Errorf("Invalid activity to send %s", err)
 	}
 
 	return a.AccessToken, nil

core/bot_framework_adapter_test.go

@@ -1,11 +1,13 @@
 package core_test
 
 import (
+	"context"
 	"fmt"
+	"os"
+
 	"github.com/infracloudio/msbotbuilder-go/core"
 	"github.com/infracloudio/msbotbuilder-go/core/activity"
 	"github.com/infracloudio/msbotbuilder-go/schema"
-	"os"
 )
 
 func Example() {
@@ -17,7 +19,7 @@ func Example() {
 	}
 
 	// Make an adapter to perform operations with the Bot Framework using this library.
-	adapter = core.NewBotAdapter(setting)
+	adapter := core.NewBotAdapter(setting)
 
 	// Create a handler that defines operations to be performed on respective events.
 	// Following defines the operation to be performed on the 'message' event.
@@ -32,15 +34,15 @@ func Example() {
 	// activity depicts a request as received from a client
 	activity := schema.Activity{
 		Type: schema.Message,
-		From: &schema.ChannelAccount{
+		From: schema.ChannelAccount{
 			ID:   "12345678",
 			Name: "Pepper's News Feed",
 		},
-		Conversation: &schema.ConversationAccount{
+		Conversation: schema.ConversationAccount{
 			ID:   "abcd1234",
 			Name: "Convo1",
 		},
-		Recipient: &schema.ChannelAccount{
+		Recipient: schema.ChannelAccount{
 			ID:   "1234abcd",
 			Name: "SteveW",
 		},
@@ -49,10 +51,10 @@ func Example() {
 	}
 
 	// Pass the activity and handler to the adapter for proecssing
-	err = adapter.ProcessActivity(ctx, activity, customHandler)
+	ctx := context.Background()
+	err := adapter.ProcessActivity(ctx, activity, customHandler)
 	if err != nil {
 		fmt.Println("Failed to process request", err)
-		http.Error(w, err.Error(), http.StatusBadRequest)
 		return
 	}
 }

hack/verify-govet.sh

@@ -7,4 +7,3 @@ set -o pipefail
 go vet ./core/...
 go vet ./schema/...
 go vet ./connector/...
-go vet ./protocol/...