Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose metrics port from loadbalancer service #138

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't expose metrics port from loadbalancer service
Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
tylerauerbeck committed Aug 29, 2023
commit 0c2ea6556792d7794094fc0ed42facbfe0309c04
1 change: 0 additions & 1 deletion internal/srv/helm.go
Original file line number Diff line number Diff line change
@@ -44,7 +44,6 @@ func (v helmvalues) generateLBHelmVals(lb *loadBalancer, s *Server) {

// add metrics port
cport = append(cport, map[string]interface{}{"name": "infra9-metrics", "containerPort": s.MetricsPort})
sport = append(sport, map[string]interface{}{"name": "infra9-metrics", "port": s.MetricsPort})

if cport != nil {
if cports, err := json.Marshal(cport); err != nil {