[events] Support ephemeral consumers #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Siwiec <[email protected]>
nicolerenee
previously approved these changes
Jan 19, 2024
mikemrm
requested changes
Jan 22, 2024
events/nats_config.go
Outdated
| @@ -55,7 +55,11 @@ type NATSConfig struct { | |||
|
|
|||
| // Configured checks whether the provider has been configured. | |||
| func (c NATSConfig) Configured() bool { | |||
| return c.URL != "" || c.QueueGroup != "" | |||
| if c.QueueGroup == "" { | |||
| c.logger.Warn("NATS QueueGroup is not set. Subscriptions will not be durable.") | |||
There was a problem hiding this comment.
This warning should go in NewNATSConnection function. This method is to determine whether this config has a configuration defined.
Signed-off-by: Matt Siwiec <[email protected]>
mikemrm
approved these changes
Jan 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadbalancer-manager-haproxy does not have a need for durable message queues, as we want each instance to consume all messages received related to loadbalancers.
Currently, we generate a unique durable queue for each manager instance, which eventually puts strain on nats with the number of consumers that can be generated over time. This PR aims to put support for ephemeral consumers back into event subscriptions, if requested, by leaving
QueueGroupempty in the nats config.