Allow disabling stack traces, add test. #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyjcarpenter
force-pushed
the
stacktrace
branch
from
03bd2a9 to
f3e19db
Compare
tommyjcarpenter
requested review from
nicolerenee and
sfunkhouser
as code owners
tommyjcarpenter
commented
Apr 2, 2024
Signed-off-by: Tommy Carpenter <[email protected]>
tommyjcarpenter
force-pushed
the
stacktrace
branch
from
f3e19db to
e8f3c18
Compare
mikemrm
requested changes
Apr 2, 2024
Signed-off-by: Tommy Carpenter <[email protected]>
tommyjcarpenter
force-pushed
the
stacktrace
branch
from
ac11bc8 to
d46348e
Compare
mikemrm
requested changes
Apr 2, 2024
Signed-off-by: Tommy Carpenter <[email protected]>
tommyjcarpenter
force-pushed
the
stacktrace
branch
from
b5e643f to
f8bed4a
Compare
Signed-off-by: Tommy Carpenter <[email protected]>
sfunkhouser
previously approved these changes
Apr 2, 2024
nicolerenee
requested changes
Apr 2, 2024
Signed-off-by: Tommy Carpenter <[email protected]>
nicolerenee
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the optional ability to turn off stack traces. It preserves current behavior of including them.
This option is available to users that are instantiating a logger themselves, but its not currently exposed to users of InitLoggerX
An alternative would have been to not do
lgrCfg := zap.NewProductionConfig()inside the function and instead take a zap config, but thats not the way the original code was written.