Refactor of AMQP-1.0 connector #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connector/amqp10/amqp10.go
Outdated
| SendTimeout int64 | ||
| ListenPrefetch int64 | ||
| LinkFailureLimit int64 | ||
| MaxParalelSendLimit int64 |
There was a problem hiding this comment.
It's also in the config (around L156), not strictly only variables in the code.
connector/amqp10/amqp10.go
Outdated
| defaultClientName = "localhost" | ||
| defaultLinkFailureLimit = 20 | ||
| defaultMaxParalelSend = 128 |
vyzigold
reviewed
Apr 26, 2024
connector/amqp10/amqp10.go
Outdated
|
|
||
| if failure { | ||
| conn.logger.Warn("Too many link failures in row, reconnecting") | ||
| err := fmt.Errorf("") //conn.Reconnect("out", outchan, &wg) |
There was a problem hiding this comment.
I don't think this and the line after it make sense. Maybe some remnant from debugging?
There was a problem hiding this comment.
Yes indeed. The reconnect logic is missing. Will add it.
Currently used library is deprecated. This patch makes connector use Azure/go-amqp instead.
vyzigold
approved these changes
Apr 30, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently used library is deprecated. This patch makes connector use Azure/go-amqp instead.