Fix concurrent deadlock #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramite
force-pushed
the
map-deadlock-fix
branch
2 times, most recently
from
db4695d to
eb8eb30
Compare
Receivers loops were not stopped when Reconnect was called, which might have get to a corner case where the loop could iterate on a conn.receivers map in the middle of recreation process. This patch is fixing it.
vyzigold
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receivers loops were not stopped when Reconnect was called, which might have get to a corner case where the loop could iterate on a conn.receivers map in the middle of recreation process. This patch is fixing it.