update ing info #293

WSbaikaishui · 2025-02-18T06:26:31Z

update ing info

Summary by CodeRabbit

New Features
- Introduced a new asset list for the ing blockchain with a defined schema.
- Added a comprehensive configuration for the ing testnet, including network metadata, API endpoints, and connectivity details.
- Updated the platform profile by renaming the identifier from "infinity-ground" to "ing" for improved consistency and changed the status to "live".
- Introduced new VIP actions within the profile configuration.

coderabbitai · 2025-02-18T06:26:38Z

Walkthrough

This pull request introduces several configuration files in the testnets/ing directory. A new asset list JSON file defines the asset details for the "ing" blockchain. Additionally, a new chain configuration JSON specifies chain metadata, connectivity endpoints, and operational parameters. The profile JSON is updated to use the identifier "ing" instead of "infinity-ground" and reflects a status change from "upcoming" to "live", along with the introduction of a new VIP object.

Changes

File(s)	Change Summary
testnets/ing/assetlist.json, testnets/ing/chain.json	Added new JSON configuration files for the "ing" blockchain testnet. The asset list defines the asset details, while the chain configuration provides metadata, node settings, endpoints, and other operational details.
testnets/ing/profile.json	Updated the profile configuration by changing the `"name"` field from `"infinity-ground"` to `"ing"` and modifying the `"status"` field from `"upcoming"` to `"live"`. A new `"vip"` object with actions was also introduced.

Possibly related PRs

Add name field in profile.json #272: Directly related to the profile "name" field update via schema modifications.

Suggested reviewers

ALPAC-4
simcheolhwan

Poem

I'm a rabbit scurrying in lines of code,
Hopping on JSON fields down the configuration road.
New assets and chains make my heart skip a beat,
With names and metadata all crisp and neat.
Thump-thump with joy, in this tech burrow so bright—
Code and carrots, coding delight! 🐰💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50d5830 and dde1b9d.

📒 Files selected for processing (1)

testnets/ing/assetlist.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

testnets/ing/assetlist.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ALPAC-4

Hi folder name must be same with chain_name can you change folder name or chain_name? Thank you

testnets/infinity-ground/assetlist.json

coderabbitai

Actionable comments posted: 0

🔭 Outside diff range comments (1)

testnets/ing/chain.json (1)

121-122: ⚠️ Potential issue

Trailing Content Removal

There is extraneous content after the closing brace (line 122). This stray text will render the JSON invalid. Please remove this extra line.

🧹 Nitpick comments (1)

testnets/ing/chain.json (1)

93-101: Explorer & Image URI Consistency

While the "explorers" array is empty (which is fine at this stage), note that both the "images" and "logo_URIs" sections reference the "infinity-ground" directory. If the branding is migrating to "ing," consider updating these paths for consistency.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c962e8 and 44f4d9a.

⛔ Files ignored due to path filters (3)

testnets/ing/images/logo-full.png is excluded by !**/*.png
testnets/ing/images/logo-pixelated.png is excluded by !**/*.png
testnets/ing/images/logo.png is excluded by !**/*.png

📒 Files selected for processing (3)

testnets/ing/assetlist.json (1 hunks)
testnets/ing/chain.json (1 hunks)
testnets/ing/profile.json (1 hunks)

✅ Files skipped from review due to trivial changes (2)

testnets/ing/profile.json
testnets/ing/assetlist.json

🔇 Additional comments (6)

testnets/ing/chain.json (6)

1-13: Schema and Basic Chain Configuration Validity

The configuration correctly references the shared schema and sets essential chain properties (chain_name, chain_id, evm_chain_id, etc.). This section looks consistent with typical testnet settings.

14-20: Website and Token Configuration

The website URL is provided and the fee/staking token arrays are intentionally left empty. This is acceptable for an upcoming testnet, assuming tokens aren’t yet defined.

21-31: Codebase Section Review

The "codebase" block lists the Git repository, the recommended version, compatible versions, and binaries for multiple platforms. Please verify that the binary URLs are current and that the recommended version ("v0.7.1-1") matches the intended release.

32-35: Peer Configuration Validity

Both seeds and persistent_peers arrays are empty. This is acceptable for an emerging testnet configuration.

36-92: API Endpoints Configuration

The API endpoints are comprehensively defined across RPC, REST, gRPC, JSON-RPC, and JSON-RPC WebSocket protocols. All URL patterns appear valid. Ensure that these endpoints are operational and conform to the network requirements for the new testnet.

102-120: Metadata Section Consistency

The metadata block details operational parameters, including op_bridge_id, op_denoms, executor_uri, and IBC channel details. The nested "minitia" information looks standard. Verify that the "assetlist" URL and IBC channel configurations align with the updated testnet deployment.

WSbaikaishui · 2025-02-19T08:36:22Z

@ALPAC-4
the response are as follow:
"supply": [
{
"denom": "GAS",
"amount": "500000000"
}
],
"pagination": {
"next_key": null,
"total": "1"
}
}
that's means base should be GAS?

ALPAC-4

On your chain. In your chain does not have a coin that denom is uinit. base must be one of the denom.

ALPAC-4 · 2025-02-20T03:17:03Z

testnets/ing/chain.json

+  "$schema": "../../chain.schema.json",
+  "chain_name": "ing",
+  "chain_id": "ing-1",
+  "evm_chain_id": 930997494890041,


evm_chain_id and metadata.op_bridge_id is incorrect. Can you check the anvil's chain.json and make these correct?

update ing info

4c962e8

ALPAC-4 requested changes Feb 18, 2025

View reviewed changes

testnets/infinity-ground/assetlist.json Outdated Show resolved Hide resolved

WSbaikaishui requested a review from ALPAC-4 February 19, 2025 02:08

update folder name

44f4d9a

coderabbitai bot reviewed Feb 19, 2025

View reviewed changes

update profile.json

50d5830

ALPAC-4 reviewed Feb 19, 2025

View reviewed changes

update assetlist.json

dde1b9d

ALPAC-4 approved these changes Feb 20, 2025

View reviewed changes

ALPAC-4 requested changes Feb 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update ing info #293

update ing info #293

WSbaikaishui commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

ALPAC-4 left a comment

coderabbitai bot left a comment

WSbaikaishui commented Feb 19, 2025

ALPAC-4 left a comment

ALPAC-4 Feb 20, 2025

update ing info #293

Are you sure you want to change the base?

update ing info #293

Conversation

WSbaikaishui commented Feb 18, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Feb 18, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

ALPAC-4 left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

WSbaikaishui commented Feb 19, 2025

ALPAC-4 left a comment

Choose a reason for hiding this comment

ALPAC-4 Feb 20, 2025

Choose a reason for hiding this comment

WSbaikaishui commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)