Nits: auto-close on failure, and call Close in Stop

inngest · Sep 23, 2024 · c07556c · c07556c
1 parent 061b56b
commit c07556c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/replicator/pgreplicator/pg.go b/pkg/replicator/pgreplicator/pg.go
@@ -128,6 +128,7 @@ type pg struct {
 
 func (p *pg) Stop() {
 	atomic.StoreInt32(&p.stopped, 1)
+	_ = p.Close(context.Background())
 }
 
 func (p *pg) Close(ctx context.Context) error {
@@ -180,6 +181,7 @@ func (p *pg) Connect(ctx context.Context, lsn pglogrepl.LSN) error {
 		},
 	)
 	if err != nil {
+		_ = p.Close(ctx)
 		if converted, newErr := standardizeErr(err); converted {
 			return newErr
 		}

diff --git a/pkg/replicator/pgreplicator/pgsetup/pgsetup.go b/pkg/replicator/pgreplicator/pgsetup/pgsetup.go
@@ -199,6 +199,7 @@ func (s *setup) createUser(ctx context.Context) error {
 		return s.res.UserCreated.Error
 	}
 	s.res.UserCreated.Error = nil
+	s.res.UserCreated.Complete = true
 	return nil
 }