Skip to content

Commit

Permalink
Make @inngest/test -> inngest a regular dependency (#725)
Browse files Browse the repository at this point in the history
## Summary
<!-- Succinctly describe your change, providing context, what you've
changed, and why. -->

Fixes broken JSR publishing for `@inngest/test`.

JSR doesn't support peer dependencies, though a non-optional peer
dependency is identical to a regular dependency in any modern package
manager.

Moving `inngest` to be a regular dependency of `@inngest/test` to
resolve the JSR publishing issue.

## Checklist
<!-- Tick these items off as you progress. -->
<!-- If an item isn't applicable, ideally please strikeout the item by
wrapping it in "~~"" and suffix it with "N/A My reason for skipping
this." -->
<!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" -->

- [ ] ~Added a [docs PR](https://github.com/inngest/website) that
references this PR~ N/A Bug fix
- [ ] ~Added unit/integration tests~ N/A Release CI
- [x] Added changesets if applicable
  • Loading branch information
jpwilliams authored Oct 22, 2024
1 parent d151b6d commit 63d4834
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion packages/middleware-encryption/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"cross-fetch": "^4.0.0",
"eslint": "^8.30.0",
"fetch-mock-jest": "^1.5.1",
"inngest": "^3.21.0",
"inngest": "3.21.0",
"jest": "^29.3.1",
"ts-jest": "^29.1.0",
"typescript": "~5.5.2",
Expand Down
4 changes: 1 addition & 3 deletions packages/test/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,10 @@
"author": "Inngest Inc. <[email protected]>",
"license": "Apache-2.0",
"dependencies": {
"inngest": "^3.22.12",
"tinyspy": "^3.0.2",
"ulid": "^2.3.0"
},
"peerDependencies": {
"inngest": "^3.22.12"
},
"devDependencies": {
"prettier": "^3.1.0"
}
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 63d4834

Please sign in to comment.