Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable and warn on step tool usage after execution #774

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jpwilliams
Copy link
Member

Summary

If a step.**() tool is called after a particular execution has finished, this means that some userland code is holding on to the reference and attempting to call it, which will always result in a hanging Promise being returned and very confusing results with the Executor.

This PR adds a small warning if this is detected.

Checklist

  • Added a docs PR that references this PR N/A Internal
  • Added unit/integration tests
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added the ⬆️ improvement Performance, reliability, or usability improvements label Dec 9, 2024
@jpwilliams jpwilliams self-assigned this Dec 9, 2024
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 376032e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jpwilliams jpwilliams requested a review from tonyhb December 9, 2024 15:40
@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants