Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocked lib tests not using real Inngest client #172

Merged
merged 2 commits into from
Oct 22, 2024
+42 −41
Merged

Fix mocked lib tests not using real Inngest client #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de70c6a
Fix mocked lib tests not using real Inngest client
amh4r Oct 14, 2024
04ef5bc
Tweak import
amh4r Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 42 additions & 41 deletions inngest/experimental/mocked/trigger_test.py
View file
Original file line number Diff line number Diff line change
@@ -5,13 +5,12 @@
import pytest

import inngest
from inngest.experimental import mocked

from .client import Inngest
from .consts import Status, Timeout
from .errors import UnstubbedStepError
from .trigger import trigger

client = Inngest(app_id="test")
client = inngest.Inngest(app_id="my-app")
client_mock = mocked.Inngest(app_id="test")


class TestTriggerAsync(unittest.TestCase):
@@ -31,8 +30,8 @@ async def fn(
)
)

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == ("a", "b")


@@ -48,8 +47,8 @@ def fn(
) -> str:
return "hi"

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == "hi"

def test_two_steps(self) -> None:
@@ -65,11 +64,17 @@ def fn(
step.run("b", lambda: None)
return "hi"

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == "hi"

def test_client_send(self) -> None:
"""
TODO: Figure out how to support this use case. Since the client in the
Inngest function is real, it's trying to send the event to a real
Inngest server.
"""

@client.create_function(
fn_id="test",
trigger=inngest.TriggerEvent(event="test"),
@@ -85,12 +90,8 @@ def fn(
]
)

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
assert res.output == [
"00000000000000000000000000",
"00000000000000000000000000",
]
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.FAILED

def test_send_event(self) -> None:
@client.create_function(
@@ -109,8 +110,8 @@ def fn(
],
)

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == [
"00000000000000000000000000",
"00000000000000000000000000",
@@ -131,13 +132,13 @@ def fn(
function_id="bar",
)

res = trigger(
res = mocked.trigger(
fn,
inngest.Event(name="test"),
client,
client_mock,
step_stubs={"a": "hi"},
)
assert res.status is Status.COMPLETED
assert res.status is mocked.Status.COMPLETED
assert res.output == "hi"

def test_parallel(self) -> None:
@@ -156,8 +157,8 @@ def fn(
)
)

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == ("a", "b")

def test_sleep(self) -> None:
@@ -172,8 +173,8 @@ def fn(
step.sleep("a", datetime.timedelta(seconds=1))
return "hi"

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == "hi"

def test_wait_for_event(self) -> None:
@@ -193,15 +194,15 @@ def fn(
assert event is not None
return event.data

res = trigger(
res = mocked.trigger(
fn,
inngest.Event(name="test"),
client,
client_mock,
step_stubs={
"a": inngest.Event(data={"foo": 1}, name="other-event")
},
)
assert res.status is Status.COMPLETED
assert res.status is mocked.Status.COMPLETED
assert res.output == {"foo": 1}

def test_wait_for_event_timeout(self) -> None:
@@ -220,13 +221,13 @@ def fn(
)
assert event is None

res = trigger(
res = mocked.trigger(
fn,
inngest.Event(name="test"),
client,
step_stubs={"a": Timeout},
client_mock,
step_stubs={"a": mocked.Timeout},
)
assert res.status is Status.COMPLETED
assert res.status is mocked.Status.COMPLETED

def test_wait_for_event_not_stubbed(self) -> None:
@client.create_function(
@@ -244,7 +245,7 @@ def fn(
)

with pytest.raises(UnstubbedStepError):
trigger(fn, inngest.Event(name="test"), client)
mocked.trigger(fn, inngest.Event(name="test"), client_mock)

def test_retry_step(self) -> None:
counter = 0
@@ -266,8 +267,8 @@ def a() -> str:

return step.run("a", a)

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == "hi"

def test_fail_step(self) -> None:
@@ -285,8 +286,8 @@ def a() -> None:

step.run("a", a)

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.FAILED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.FAILED
assert res.output is None
assert isinstance(res.error, Exception)
assert str(res.error) == "oh no"
@@ -308,8 +309,8 @@ def fn(
raise Exception("oh no")
return "hi"

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.COMPLETED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.COMPLETED
assert res.output == "hi"

def test_fail_fn(self) -> None:
@@ -324,8 +325,8 @@ def fn(
) -> None:
raise Exception("oh no")

res = trigger(fn, inngest.Event(name="test"), client)
assert res.status is Status.FAILED
res = mocked.trigger(fn, inngest.Event(name="test"), client_mock)
assert res.status is mocked.Status.FAILED
assert res.output is None
assert isinstance(res.error, Exception)
assert str(res.error) == "oh no"