Add dev_server library #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwilliams
approved these changes
Oct 15, 2024
Comment on lines
+42
to
+58
| self._process = subprocess.Popen( | ||
| [ | ||
| "npx", | ||
| "--yes", | ||
| "inngest-cli@latest", | ||
| "dev", | ||
| "--no-discovery", | ||
| "--no-poll", | ||
| "--port", | ||
| f"{self.port}", | ||
| ], | ||
| bufsize=1, | ||
| stderr=subprocess.STDOUT, | ||
| stdout=subprocess.PIPE, | ||
| text=True, | ||
| universal_newlines=True, | ||
| ) |
There was a problem hiding this comment.
Might be good to move away from npx for the Python SDK when this comes out of experimental - npm could be an extra tool folks have to install.
Not sure what we've move to, though, outside of managing a /tmp/ version where we install the binary directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
inngest.experimental.dev_serverlibrary, which is used to start and stop a Dev Server during integration testing. It's dogfooded in all of this repo's integration tests.