Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply JCS before signature validation #54

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Aug 23, 2024

Fix signature validation errors by applying JCS before signature validation. Sometimes the request body has escape sequences (e.g. \u0026 instead of &) that weren't present when Inngest Cloud created the signature

@amh4r amh4r requested a review from tonyhb August 23, 2024 18:23
@amh4r amh4r merged commit 9e60ab4 into main Aug 23, 2024
6 checks passed
@amh4r amh4r deleted the jcs-before-sig-validation branch August 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants