Impact of switching from lowercase to uppercase first character

[ReactorShop]

This is what needs to be changed when switching from e.g. "add new line"
to "Add New Line", plus other minor fixes. The gettext translation terms
must match case and spacing.

[ReactorShop]

The "Added sorting capability to array of classes" commit, refers to sorting lists, like the currency one and maybe others which are long and may require some effort in order to locate a specific value within them.

[inoerp]

Appreciate your effort but don't think we need to have the sorting parameter in select_field as that's already taken care of by the object itself (the object used in the function).

[inoerp]

Sorting can be done using the existing second parameter. So, no need to add a new one

[ReactorShop]

Hi @inoerp. These are the two class_inofrm.inc functions used to process the currency classes' currency code into an html select list:

public function l_select_field_from_object($name, $object, $objectValueKey, $objectDescriptionKey, $value = "", $id = "", $divClass = "", $required = "", $readonly = "", $convertToText = "", $nonArrayName = "", $disabled = "", $dataname = '') { echo '<label>' . gettext(ucwords(str_replace('_', ' ', $name))) . '</label>'; echo $this->select_field_from_object($name, $object, $objectValueKey, $objectDescriptionKey, $value, $id, $divClass, $required, $readonly, $convertToText, $nonArrayName, $disabled, $dataname); }

Which then calls:

`public function select_field_from_object($name, $object, $objectValueKey, $objectDescriptionKey, $value = "", $id = "", $divClass = "", $required = "", $readonly = "", $convertToText = "", $nonArrayName = "", $disabled = "", $dataname = '') {
$value = htmlentities($value, ENT_QUOTES, 'UTF-8');
$objectValueKey = strtolower($objectValueKey);
if ($nonArrayName == 1) {
$bracketName = $name;
} else {
$bracketName = $name . '[]';
}
$idvalue = $this->_convert_id($id);
if ($readonly == 1) {
$readonly = 'disabled';
} else {
$readonly = '';
}

if ($required == 1) {
$required = 'required';
} else {
$required = '';
}

if ($disabled == 1) {
$disabled = 'disbaled';
} else {
$disabled = '';
}
$element_select_field = "<Select name="$bracketName" class="select $divClass $name" $idvalue $readonly $required $disabled>";
$element_select_field .= "<option value="" >" . gettext('Select') . "";
if ((is_array($object)) && (count($object) > 0 )) {
foreach ($object as $record) {
if ((!empty($value)) && ($record->$objectValueKey == $value)) {
$selected = 'selected';
} else {
$selected = '';
}

$element_select_field .= '<option value="' . $record->$objectValueKey . '" ';
$element_select_field .= $selected;
if (!empty($dataname)) {
 if (is_array($dataname)) {
  foreach ($dataname as $dataname_k => $dataname_v) {
   $element_select_field .= " data-$dataname_v='" . $record->$dataname_v . "' ";
  }
 } else {
  $element_select_field .= " data-$dataname='" . $record->$dataname . "' ";
 }
}
$element_select_field .= '>';
if (is_array($objectDescriptionKey)) {
 $newValue1 = '';
 foreach ($objectDescriptionKey as $keya => $valuea) {
  $newValue1 .= $record->$valuea . ' | ';
 }
 $newValue = rtrim($newValue1, ' | ');
} else {
 $objectDescriptionKey = strtolower($objectDescriptionKey);
 $newValue = $record->$objectDescriptionKey;
}
$element_select_field .= $newValue;
$element_select_field .= '</option>';

}
}

if ($convertToText == 1) {
$element_select_field .= "<option value="newentry" class="bold blue">" . gettext('New Entry') . "";
}
$element_select_field .= '';

return $element_select_field;
}`

The second parameter of this function is $object, which is the array of currency classes that contain the currency code in need of sorting, and we're talking about sorting this array of classes using one of their class properties (the currency code) as the criteria, which is covered by the usort added to this function.

Can you please help me point out which parameter is the one that sorts the array of objects using a class property as the criteria?

Regards!

[inoerp]

can't we pass the parameter $object after sorting ?
Does it make more sense to do the sorting in this function instead of at the source of the object?
There is nothing horribly wrong about having the sort feature in the function but its a matter of principle of decoupling.

Below is the code for currency
Public static function currencies() { $option_header = self::find_by_name('CURRENCY'); $ol = new option_line(); $currencies = $ol->findBy_parentId($option_header->option_header_id, 'option_line_value'); return $currencies; }

Below is the code for findBy_parentId
` public function findBy_parentId($id, $order_by_field = '', $order_by_seq = '') {
global $dbc;
$order_by_field = empty($order_by_field) ? static::$primary_column : $order_by_field;
$order_by_seq = empty($order_by_seq) ? 'ASC' : $order_by_seq;
if (empty($id)) {
return false;
}
$sql = " SELECT * FROM ";
$sql.= static::$table_name;
$sql.= " WHERE " . static::$parent_primary_column . " = :primary_id ";
if (!empty($order_by_field)) {
$sql.= " ORDER BY {$order_by_field} ";
$sql.= " $order_by_seq ";
}

$stmt = $dbc->connection->prepare(" $sql ");
$stmt->bindParam(':primary_id', $id);
try {
$stmt->execute();
$result = $stmt->fetchAll(PDO::FETCH_CLASS);
} catch (PDOException $e) {
echo ino_show_debug_msg('Failed to read the data ', $e->getMessage(), $sql, ' Error @dbObject @@ Line " '.LINE);
}
return !empty($result) ? $result : false;
}`

[ReactorShop]

The function will need to be hardcoded like this:

Public static function currencies() { $option_header = self::find_by_name('CURRENCY'); $ol = new option_line(); $currencies = $ol->findBy_parentId($option_header->option_header_id, 'option_line_value'); usort($currencies, function ($a, $b) { return $a->option_line_code <=> $b->option_line_code; }); return $currencies; }

This will only work with currencies, but I can do the same thing if I find another array of classes that requires sorting.

I already tested it and it works as expected.

I'm going to provide a commit that will remove my previous attempt and will provide this modification.

Regards

[inoerp]

You don't need that either as sorting is done findBy_parentId
Below will work
Public static function currencies() { $option_header = self::find_by_name('CURRENCY'); $ol = new option_line(); $currencies = $ol->findBy_parentId($option_header->option_header_id, 'option_line_code'); return $currencies; }

Just need to modify the parameter to option_line_code from option_line_value

[ReactorShop]

As I said, I didn't check the findBy_parentId method, and I apologize. Here's how the PO Requisition Header screen looks like completely translated into Spanish, with the currency code sorted:

Thank you!

[ReactorShop]

For the two latest commits, I'm going to apply the htmlentities() function so that we don't need to write the page title strings as html entities. I'll provide later a commit applying this modification.

[ReactorShop]

AFAIK, in Spanish we don't use the ampersand, so this is a screen shot of a Spanish translation modified to include the ampersand as text in the clear, removing the htmlentities or htmlspecialchars I added before to test.

It works as expected,