Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing people.html file #104

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Missing people.html file #104

wants to merge 3 commits into from

Conversation

modonovan
Copy link
Collaborator

Hi folks,

Looking to merge these changes to master as I noticed when looking through the site today that pc.html had a broken link for the actual people on the committee.

Assuming this was an oversight but made a start as per the commits.

Hope it helps.

Mick

Copy link
Contributor

@donalod donalod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to have your energy and contribution! We need to put together a good guide too for branches and commits but this is a great start. Few questions just for clarity:

a) maybe can drop Darren and Jose as they are not really active ATM in any way...
b) + will need to check with Oli and Amanda (et al) about putting their full details up (indeed with everyone I think, before we link to front page matter (just to set expectations))...

@modonovan
Copy link
Collaborator Author

Awesome to have your energy and contribution! We need to put together a good guide too for branches and commits but this is a great start. Few questions just for clarity:

a) maybe can drop Darren and Jose as they are not really active ATM in any way...
b) + will need to check with Oli and Amanda (et al) about putting their full details up (indeed with everyone I think, before we link to front page matter (just to set expectations))...

Both suggestions make sense. Happy to help / resubmit / whatever you need.

@donalod
Copy link
Contributor

donalod commented Jun 24, 2019

Yea, I reckon if you do a simple ask in #PC about people being on the people page (+ could even solicit what deets they are happy having up) and drop Darren + Jose FTW!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants