Preparing floats for V11C version #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 26, 2024 17:21
remove treating_coriolis() and put all the content in chla_algorithm() Using Unicode in dtype for strings, to avoid .decode()
|
We are also removing scipy.io as NetCDF and writing SUPERFLOAT as netCDF-4 files |
added 2 commits
October 1, 2024 10:29
In addition - use pathlib - Use with in opening NetCDF file - Fixing bug about nitrate_already_existing logical: used with —force variables were created in any case, now variables are created only if they don’t exist.
|
UserWarning: The seawater library is deprecated! Please use gsw instead. We have to test this gsw. |
|
@CarolinaAmadio, @lfeudale Shall we remove it ? And believe in new coriolis products?
|
added 2 commits
October 8, 2024 15:32
fixing NetCDF generation demoving .decode()
|
According to https://fleetmonitoring.euro-argo.eu/, these floats have issues labeled as "[FLAG_MissingVerticalProfile_LOGICAL]," which indicates a problem with the PRES variable. However, this issue is not strictly related to the DOXY variable. I suggest removing this Python function, also because we already perform checks on PRES (e.g., LEN pres must be > 5). |
fixing NetCDF generation
demoving .decode()
…loat_ph.py fixing NetCDF generation demoving .decode()
…m deliverables.metrics (instead of metrics2)
Remove duplicates like metrics2 or online/metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing improvements defined in #16