Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from galactic to humble #31

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

nv-yuzho
Copy link
Contributor

@nv-yuzho nv-yuzho commented Dec 1, 2022

No description provided.

@leandropineda
Copy link
Member

Hi @nv-yuzho !

Would you mind retargeting the PR against humble-devel? I just created it.

Why did you rename the package to vda5050_connector_py?

@nv-yuzho nv-yuzho changed the base branch from galactic-devel to humble-devel December 6, 2022 22:34
@nv-yuzho
Copy link
Contributor Author

nv-yuzho commented Dec 6, 2022

Hi @nv-yuzho !

Would you mind retargeting the PR against humble-devel? I just created it.

Why did you rename the package to vda5050_connector_py?

Hi @leandropineda! Yeah, I wanted to merge it to humble-devel but couldn't create one. Could you create one for the vda5050_adapter_examples repo as well?
Regarding the rename, there is a known issue mentioned in the warning here and on another GitHub Issue. We wanted to mix action generator and python, but the ament_cmake_python commands couldn't handle this case very well. Thus I need to change the name of one python module to avoid conflict, otherwise, it would run into build errors. Not sure why it was ok for ROS galactic though.

@leandropineda
Copy link
Member

I finally got the time to go through your PR @nv-yuzho and test everything. Thanks for your contribution! I'll continue with the PRs on https://github.com/inorbit-ai/vda5050_adapter_examples

@leandropineda leandropineda merged commit 22dc24f into inorbit-ai:humble-devel Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants