Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the pull request template with info about the review assignees #2963

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update the pull request template with info about the review assignees #2963

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c5f484
Update the pull request template with information about the reviewers…
szymonmaslowski Apr 20, 2022
49be387
Merge branch 'develop' into chore/reviewers-PR-template
szymonmaslowski Apr 20, 2022
861530a
Remove unnecessary '.'
szymonmaslowski Apr 21, 2022
df86294
Merge branch 'develop' into chore/reviewers-PR-template
szymonmaslowski May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Open a thread on #daedalus-qa on Slack, mention `@daedalusqa` and `@daedalusteam
### Basics

- [ ] PR assigned to the PR author(s)
- [ ] `input-output-hk/daedalus-dev` and `input-output-hk/daedalus-qa` assigned as PR reviewers
- [ ] Teammates from your squad (and those familiar with changed part of the app) are assigned as PR reviewers
- [ ] If there are UI changes, Alexander Rukin assigned as an additional reviewer
- [ ] All visual regression testing has been reviewed (assign `run Chromatic` label to PR to trigger the run)
- [ ] PR has appropriate labels (`release-vNext`, `feature`/`bug`/`chore`, `WIP`)
Expand Down