Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement client for CardanoDatabase in client library (list and get) #2255

Merged
merged 8 commits into from
Jan 28, 2025
Merged

Feat: implement client for CardanoDatabase in client library (list and get) #2255

merged 8 commits into from
Jan 28, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 27, 2025 •
edited
Loading

Content

This PR includes the implementation of a client for the CardanoDatabase signed entity type in the client library (limited to get and list snapshots).

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #2214

@jpraynaud jpraynaud self-assigned this Jan 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Test Results

    4 files  ± 0     52 suites  ±0   10m 34s ⏱️ +18s
1 551 tests + 6  1 551 ✅ + 6  0 💤 ±0  0 ❌ ±0 
1 825 runs  +24  1 825 ✅ +24  0 💤 ±0  0 ❌ ±0 

Results for commit d29dbd8. ± Comparison against base commit dddc0ee.

This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both. 
mithril-client ‑ cardano_stake_distribution_client::tests::list_mithril_stake_distributions_returns_error_when_invalid_json_structure_in_response
mithril-client ‑ cardano_stake_distribution_client::tests::list_mithril_stake_distributions_returns_messages

mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_error
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_error_when_invalid_json_structure_in_response
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_message
mithril-client ‑ cardano_database_client::tests::get_cardano_database_snapshot_returns_none_when_not_found_or_remote_server_logical_error
mithril-client ‑ cardano_database_client::tests::list_cardano_database_snapshots_returns_error_when_invalid_json_structure_in_response
mithril-client ‑ cardano_database_client::tests::list_cardano_database_snapshots_returns_messages
mithril-client ‑ cardano_stake_distribution_client::tests::list_cardano_stake_distributions_returns_error_when_invalid_json_structure_in_response
mithril-client ‑ cardano_stake_distribution_client::tests::list_cardano_stake_distributions_returns_messages

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 27, 2025 16:26 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review January 27, 2025 16:29
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database branch from b60c8a0 to 9f9f225 Compare January 27, 2025 16:59
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 27, 2025 17:08 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

mithril-client/src/aggregator_client.rs Outdated Show resolved Hide resolved
mithril-client/src/aggregator_client.rs Outdated Show resolved Hide resolved
mithril-client/src/aggregator_client.rs Outdated Show resolved Hide resolved
mithril-client/src/lib.rs Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database branch from 9f9f225 to 4f44d3c Compare January 27, 2025 17:48
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 27, 2025 17:57 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alenar
Alenar approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mithril-client/src/cardano_database_client.rs Outdated Show resolved Hide resolved
mithril-client/src/type_alias.rs Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database branch from 4f44d3c to a443cf9 Compare January 28, 2025 10:41
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 28, 2025 10:49 — with GitHub Actions Inactive
@jpraynaud
feat: make Cardano database client unstable
1c1c487
@jpraynaud
docs: update CHANGELOG
94d8801
@jpraynaud
chore: upgrade crate versions
d29dbd8 
* mithril-client from `0.10.8` to `0.10.9`
* mithril-common from `0.4.108` to `0.4.109`
@jpraynaud jpraynaud force-pushed the jpraynaud/2214-client-library-cardano-database branch from a443cf9 to d29dbd8 Compare January 28, 2025 11:03
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 28, 2025 11:12 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 50384c9 into main Jan 28, 2025
43 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/2214-client-library-cardano-database branch January 28, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@sfauvel sfauvel sfauvel approved these changes

@dlachaume dlachaume dlachaume approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpraynaud @Alenar @sfauvel @dlachaume