Fix split list for pagination when with ordered factors #235
+62
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Tests Summary 1 files 5 suites 9s ⏱️ For more details on these errors, see this check. Results for commit f24b64c. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 978c5d8 ♻️ This comment has been updated with latest results. |
This was
linked to
issues
Nov 22, 2024
shajoezhu
requested changes
Nov 23, 2024
There was a problem hiding this comment.
hi @Melkiades , thanks for the fix, tests currently failing, can you also add a test to
https://github.com/insightsengineering/scda.test/blob/main/tests/testthat/test-pagination_listing.R as well. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234 #225