update strata var to group_var

[ayogasekaram]

to match control_lineplot_vars() in tern

closes #1245

[github-actions]

Unit Tests Summary

    1 files     70 suites   1h 8m 36s ⏱️
  724 tests   583 ✅ 110 💤 31 ❌
1 994 runs  1 724 ✅ 225 💤 45 ❌

For more details on these failures, see this check.

Results for commit ae7e067.

♻️ This comment has been updated with latest results.

[edelarua]

Looks good! Can you keep the strata argument in tm_g_lineplot() and start a deprecation cycle for it in case people are unaware of the name change?

Thanks!

[github-actions]

Unit Test Performance Difference

Test suite performance difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_mmrm	💚	$736.91$	$-4.07$	$0$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	💚	$236.45$	$-5.77$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	💚	$145.66$	$-3.31$	$0$	$0$	$0$	$0$
shinytest2-tm_g_forest_tte	💚	$55.85$	$-1.33$	$0$	$0$	$0$	$0$
shinytest2-tm_g_ipp	💚	$112.04$	$-2.98$	$0$	$0$	$0$	$0$
shinytest2-tm_g_km	💚	$275.43$	$-7.72$	$0$	$0$	$0$	$0$
shinytest2-tm_g_lineplot	💚	$89.98$	$-2.95$	$+10$	$0$	$+5$	$0$
shinytest2-tm_g_pp_adverse_events	💚	$126.57$	$-3.96$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_patient_timeline	💚	$252.38$	$-7.04$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_therapy	💚	$173.14$	$-3.57$	$0$	$0$	$0$	$0$
shinytest2-tm_g_pp_vitals	💚	$89.49$	$-2.45$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality	💚	$69.46$	$-1.25$	$0$	$0$	$0$	$0$
shinytest2-tm_t_abnormality_by_worst_grade	💚	$70.49$	$-2.65$	$0$	$0$	$0$	$0$
shinytest2-tm_t_ancova	💚	$100.51$	$-4.04$	$0$	$0$	$0$	$0$
shinytest2-tm_t_binary_outcome	💚	$78.87$	$-2.05$	$0$	$0$	$0$	$0$
shinytest2-tm_t_coxreg	💚	$75.21$	$-1.41$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events	💚	$62.61$	$-1.72$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_by_grade	💚	$92.46$	$-3.49$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_patyear	💚	$52.92$	$-2.40$	$0$	$0$	$0$	$0$
shinytest2-tm_t_events_summary	💚	$69.34$	$-2.53$	$0$	$0$	$0$	$0$
shinytest2-tm_t_exposure	💚	$80.14$	$-3.62$	$0$	$0$	$0$	$0$
shinytest2-tm_t_logistic	💚	$62.57$	$-2.87$	$0$	$0$	$0$	$0$
shinytest2-tm_t_mult_events	💚	$60.32$	$-3.60$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_basic_info	💚	$42.71$	$-2.01$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_laboratory	💚	$131.99$	$-2.97$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_medical_history	💚	$67.78$	$-2.27$	$0$	$0$	$0$	$0$
shinytest2-tm_t_pp_prior_medication	💚	$78.45$	$-2.75$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm	💚	$60.09$	$-1.97$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_arm_by_worst	💚	$92.24$	$-3.93$	$0$	$0$	$0$	$0$
shinytest2-tm_t_shift_by_grade	💚	$82.40$	$-2.54$	$0$	$0$	$0$	$0$
shinytest2-tm_t_smq	💚	$61.15$	$-2.66$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary	💚	$40.69$	$-1.22$	$0$	$0$	$0$	$0$
shinytest2-tm_t_summary_by	💚	$82.44$	$-1.22$	$0$	$0$	$0$	$0$
shinytest2-tm_t_tte	💚	$68.81$	$-1.31$	$0$	$0$	$0$	$0$

Results for commit c971325

♻️ This comment has been updated with latest results.

[edelarua]

Hi @ayogasekaram,

A few suggestions from me, plus a fix for the missing argument error! :)

[edelarua]

Good to go now - thanks Abi!!

[ayogasekaram]

Hey @shajoezhu
FYI: I think I'm running into the same test failures as Emily mentioned in the other PR.

[shajoezhu]

blocked by #1248