Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tm_t_summary_by() column variable text #1247

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Nov 14, 2024

Pull Request

Fixes #1244

Text now aligns with tm_t_summary() column variable text.

@edelarua edelarua added the sme label Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Unit Tests Summary

    1 files     69 suites   1h 6m 43s ⏱️
  701 tests   591 ✅ 110 💤 0 ❌
1 925 runs  1 700 ✅ 225 💤 0 ❌

Results for commit 811f409.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @edelarua

@shajoezhu shajoezhu self-assigned this Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💚 $139.86$ $-3.28$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💚 $743.33$ $-11.04$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $240.20$ $-10.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $101.78$ $-2.14$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $179.15$ $-3.18$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💚 $111.45$ $-1.71$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $271.48$ $-1.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $125.16$ $-3.04$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $251.01$ $-4.89$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💚 $90.25$ $-2.45$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💚 $68.85$ $-1.61$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $68.64$ $-1.32$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $97.20$ $-1.51$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $77.43$ $-2.49$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $74.31$ $-2.12$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💚 $61.37$ $-1.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $77.37$ $+1.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💚 $58.59$ $-1.10$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💚 $78.31$ $-2.40$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💚 $60.94$ $-2.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $95.34$ $-3.58$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $84.87$ $-4.71$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $61.46$ $-2.68$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💚 $41.83$ $-2.25$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💚 $83.75$ $-3.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💚 $68.33$ $-2.14$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💚 $29.58$ $-1.03$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💚 $48.29$ $-1.15$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_g_mmrm_lsmeans.
shinytest2-tm_a_mmrm 💚 $48.76$ $-1.16$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_cov.
shinytest2-tm_a_mmrm 💚 $48.32$ $-1.09$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_diagnostic.
shinytest2-tm_a_mmrm 💚 $49.68$ $-1.06$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.
shinytest2-tm_t_smq 💚 $8.59$ $-1.18$ e2e_tm_t_smq_Selecting_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_summary_by 💚 $26.18$ $-1.24$ e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 7b42b7c

♻️ This comment has been updated with latest results.

@edelarua
Copy link
Contributor Author

@shajoezhu some unrelated shinytest2 tests are failing (the same ones that have been failing in the integration tests for a while). Is someone looking into this already?

@shajoezhu
Copy link
Contributor

@shajoezhu some unrelated shinytest2 tests are failing (the same ones that have been failing in the integration tests for a while). Is someone looking into this already?

hey @pawelru @gogonzo @donyunardi , I was wondering if you guys had seen this before. Thanks

@shajoezhu shajoezhu enabled auto-merge (squash) November 18, 2024 02:39
@shajoezhu
Copy link
Contributor

blocked by #1248

@shajoezhu shajoezhu merged commit 35dc4c1 into main Nov 26, 2024
26 checks passed
@shajoezhu shajoezhu deleted the 1244_tm_t_summary_by_col_lbl@main branch November 26, 2024 11:25
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: Is it possible to change label of arm_var in "tm_t_summary_by" shown on left sidebar panel?
3 participants