-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force render all articles #187
Conversation
Signed-off-by: Pawel Rucki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a very expensive operation every time. I'd recommend just clearing the runner caches if we want to force render.
Unit Tests Summary 1 files 2 suites 1m 0s ⏱️ Results for commit 26077d0. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 656c7e9 ♻️ This comment has been updated with latest results. |
Yes, we should expect increased timings on each workflow run but I guess this is unavoidable if we want to test unchanged code against environment (packages) for potential incompatibility - we have to run everything.
Yes that's essentially it. Would you mind push necessary changes? |
Looks like GitHub has provided an out-of-the-box solution for cache eviction: https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries I'll add it here. |
Hey @cicdguy I noticed that caches are gone. Is there anything required from the perspective of action definition? Things like remove cache creation / push? |
When reading the logs from deployment I noticed that only part of the articles are being rendered (and the other part is taken from cache?) Few examples from the latest build:
We do want to render (cover) all the articles so as to test sufficiently against changes in the packages used. This PR aims to force render all. I hope this is enough.
This is desirable for both stable and devel profile so changes in the main config file.
Relevant docs:
https://quarto.org/docs/projects/code-execution.html#freeze
https://quarto.org/docs/projects/code-execution.html#cache