-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use setup-r-dependencies action #279
Conversation
Unit Tests Summary340 tests 252 ✅ 1m 1s ⏱️ Results for commit b002750. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceTest suite performance difference
Additional test case details
Results for commit 9ea00c9 ♻️ This comment has been updated with latest results. |
Signed-off-by: Pawel Rucki <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
Signed-off-by: Pawel Rucki <[email protected]>
Hey @pawelru is this ready for a review? R CMD Check is failiing |
Yes it is. R CMD CHECK error is unrelated and should be handled separately. I will create a separate PR and there will ask SME team for a review. Here, I want to ask for a review of changes in the actions definition |
Pawel, I think I understand changes in YAML/Actions part. I just can't help with the JS part that is changed in this PR. Would you like some other pair of eyes? |
These are actually external Quarto extension code imported (included) in here. That's how Quarto handles this - docs. I just updated this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides automated Quarto edits, no changes needed. Looks good.
Glad that we are able to use dev and stable R-universe in setup-r-dependencies
companion PRs:
cache-version
setup-r-dependencies#14