mipsy_web: fix undo/redo #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling setValue on the editor causes it to drop the current undo/redo history, and set_editor_value() is called whenever the user changes the source code. This resulted in undo/redo not working at all. This commit changes set_editor_value to only call setValue() when there's a difference between the new and old value. There's likely a nicer way of fixing this that involves set_editor_value() not being called as often -- but this change seemed least likely to introduce a bug related to a desync between the editor's and the app's view of the editor contents.
Dylan-Brotherston
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
setValueon the editor causes it to drop the current undo/redo history, andset_editor_valueis called whenever the user changes the source code. This resulted in undo/redo not working at all. This commit changesset_editor_valueto only callsetValuewhen there's a difference between the new and old value.There's likely a nicer way of fixing this that involves
set_editor_valuenot being called as often -- but this change seemed least likely to introduce a bug related to a desync between the editor's and the app's view of the editor contents.