Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Runner Options for New Docker Transport #236

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jeffreycoe
Copy link

@jeffreycoe jeffreycoe commented Jun 18, 2019

Description

Adds InSpec runner options for the Docker transport. This is to support the docker transport in this PR: test-kitchen/kitchen-docker#340

Issues Resolved

N/A

Check List

@jeffreycoe jeffreycoe force-pushed the docker-runner-opts branch from 5263187 to 3781be5 Compare June 18, 2019 19:49
Signed-off-by: Jeffrey Coe <[email protected]>
@jeffreycoe jeffreycoe changed the title Add docker transport runner options Added Runner Options for New Docker Transport Jun 19, 2019
@miah
Copy link
Contributor

miah commented Sep 5, 2019

Was there intention to add tests for this change?

lib/kitchen/verifier/inspec.rb Outdated Show resolved Hide resolved
@jeffreycoe
Copy link
Author

jeffreycoe commented Sep 18, 2019

Was there intention to add tests for this change?

Hi @miah - I have tests ready to go, but I have to add a dependency to a specific version of the kitchen-docker gem to the Gemfile. Unfortunately, a new version of the kitchen-docker gem hasn't been released yet with the latest code changes which includes the new docker transport. I'll commit the tests when the gem is released (which should happen soon).

lib/kitchen/verifier/inspec.rb Outdated Show resolved Hide resolved
@clintoncwolfe clintoncwolfe added Type: Enhancement Adds new functionality. Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. Platform: Docker labels Sep 23, 2019
@james-stocks
Copy link

Will put this on our list to review, as https://rubygems.org/gems/kitchen-docker/versions/2.10.0 was released

@james-stocks
Copy link

@jeffreycoe can this PR be closed, given that the PR it was to support (test-kitchen/kitchen-docker#340) has already merged?

@jeffreycoe jeffreycoe force-pushed the docker-runner-opts branch from f403aed to fcf24e4 Compare June 17, 2020 20:18
@jeffreycoe
Copy link
Author

@james-stocks This should be ready to merge now that 2.10.0 of the kitchen-docker gem was released with the new docker transport. I made the requested changes to use alias_method instead, and added an integration test with the latest commits.

@clintoncwolfe clintoncwolfe self-requested a review November 16, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expeditor: Bump Version Minor Used by github.minor_bump_labels to bump the Minor version number. Platform: Docker Type: Enhancement Adds new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants