Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include notification into polling #15

Merged
merged 4 commits into from
Nov 26, 2024
Merged

feat: Include notification into polling #15

merged 4 commits into from
Nov 26, 2024

Conversation

levinkerschberger
Copy link
Member

@levinkerschberger levinkerschberger commented Nov 12, 2024 •
edited
Loading

  • deleted POST /connections
  • added headers to GET /agent-configuration
  • added exception handler for missing headers in GET /agent-configuration
  • added lastFetch to connection model
  • added timeSinceLastFetch to connection dto for easy retrival of duration via frontend
  • added response header to indicate new connections
  • added tests

@levinkerschberger levinkerschberger marked this pull request as draft November 12, 2024 22:35
@levinkerschberger levinkerschberger marked this pull request as ready for review November 14, 2024 09:25
@levinkerschberger levinkerschberger force-pushed the feature/579-include-notification-in-polling branch from 9ce5950 to 6ead8cf Compare November 21, 2024 17:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@binarycoded binarycoded requested review from EddeCCC and removed request for binarycoded November 22, 2024 10:03
EddeCCC
EddeCCC requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@EddeCCC EddeCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'd suggest just some small changes

backend/src/main/java/rocks/inspectit/gepard/agentmanager/Application.java Outdated Show resolved Hide resolved
.../src/main/java/rocks/inspectit/gepard/agentmanager/connection/service/ConnectionService.java Outdated Show resolved Hide resolved
.../src/main/java/rocks/inspectit/gepard/agentmanager/connection/service/ConnectionService.java Show resolved Hide resolved
...pectit/gepard/agentmanager/configuration/validation/ConfigurationRequestHeaderValidator.java Show resolved Hide resolved
...pectit/gepard/agentmanager/configuration/validation/ConfigurationRequestHeaderValidator.java Show resolved Hide resolved
...c/test/java/rocks/inspectit/gepard/agentmanager/testutils/ConfigurationRequestTestUtils.java Outdated Show resolved Hide resolved
frontend/build.gradle Outdated Show resolved Hide resolved
@binarycoded binarycoded requested a review from EddeCCC November 26, 2024 08:45
@binarycoded binarycoded merged commit d46ab4d into main Nov 26, 2024
5 checks passed
@binarycoded binarycoded deleted the feature/579-include-notification-in-polling branch November 26, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binarycoded binarycoded binarycoded left review comments

@EddeCCC EddeCCC EddeCCC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@levinkerschberger @binarycoded @EddeCCC