Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows: fix plot extraction errors #4357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

workflows: fix plot extraction errors #4357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions inspirehep/modules/workflows/tasks/arxiv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ def arxiv_plot_extract(obj, eng):
current_app.logger.exception(err)
delete_empty_key(obj, 'figures')
return
except Exception as err:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should catch both errors as we handle them the same anyways..

except (DelegateError, Exception) as err:

obj.log.error(
'Error extracting plots for %s. Report and skip.',
arxiv_id,
)
current_app.logger.exception(err)
delete_empty_key(obj, 'figures')
return

if 'figures' in obj.data:
for figure in obj.data['figures']:
Expand Down
Loading