Replace IFormula implementation function with a value. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Aug 14, 2024
| @@ -73,7 +73,9 @@ class TestFormulaTest { | |||
| class Button(val onNameChanged: (String) -> Unit) | |||
| } | |||
|
|
|||
| class FakeChildFormula : TestFormula<ChildFormula.Input, ChildFormula.Button>(), ChildFormula { | |||
There was a problem hiding this comment.
Using testFormula in combination with implementation allows us to avoid re-typing various types that are already declared within ChildFormula
Laimiux
force-pushed
the
laimonas/formula-implementation-as-value
branch
from
28c5875 to
499add9
Compare
JaCoCo Code Coverage 83.76% ✅
Generated by 🚫 Danger |
setheclark
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
implementationfunction with a valuetestFormulaextension to simplify testing API