Add modifyOutput function to TestFormula. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laimiux
commented
Aug 22, 2024
| import com.instacart.formula.test.SimpleFormula.Input | ||
| import com.instacart.formula.test.SimpleFormula.Output | ||
|
|
||
| interface SimpleFormula : IFormula<Input, Output> { |
There was a problem hiding this comment.
Rewriting the tests using a much simpler formula.
Laimiux
commented
Aug 22, 2024
| observer.output(on) | ||
| } | ||
|
|
||
| class ParentFormula( |
There was a problem hiding this comment.
Replacing all of this with a simpler test formula
Laimiux
commented
Aug 22, 2024
| } | ||
| } | ||
|
|
||
| @Test fun `input passed to formula`() { |
Laimiux
force-pushed
the
laimonas/test-formula-modify-output
branch
from
63b1f70 to
9177e6a
Compare
JaCoCo Code Coverage 87.89% ✅
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To simplify modifying a single property of the output, I'm adding
modifyOutputfunction toTestFormula