Add Input Type Autodetection and FFT CLI Argument #46
Conversation
- Implement input type autodetection - Add FFT as a CLI argument - Check the number of provided arguments
- Implement input type autodetection - Add FFT as a CLI argument - Check the number of provided arguments - Better error handling
…file-directory-autodetect # Conflicts: # brro-compressor/src/main.rs
|
Heads up that you have a merge conflict here that needs to be resolved. |
|
mind resolving the new conflict? 😄 |
Absolutely, no problem! I've gone ahead and resolved the conflicts |
There was a problem hiding this comment.
Removing the need for the user to redundantly specify file or directory is a really nice improvement to usability!
Returning a useful error when the user gives invalid compressor type inputs is also nice.
In a follow up PR lets take this one step further, we can provide an interface to the user such that its impossible to provide multiple compression types by making a force_compression: Compressor field on Args.
You can refer to this as an example: https://github.com/shotover/shotover-proxy/blob/02c8b120d661f0e007182d5afb9c96796b658044/shotover/src/runner.rs#L47-L55
Summary:
This pull request introduces input type autodetection and adds the FFT as a CLI argument. It improves the error handling mechanism by propagating errors instead of using .expect(), and ensures the right number of arguments is provided by the user.
Changes:
Implemented a mechanism to autodetect the input type. The program now automatically identifies the type of the input, reducing the need for manual selection.
Added FFT as a CLI argument.
Integrated a check for the number of provided arguments. This addition ensures users provide the correct number of arguments.
Transitioned from using .expect() to an error propagation.
Any feedback is welcome!