Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncompressing data #51

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Uncompressing data #51

merged 3 commits into from
Oct 16, 2023

Conversation

cjrolo
Copy link
Collaborator

@cjrolo cjrolo commented Oct 16, 2023

This PR does the following changes:

  • Creates the decompress_data function to generate a CompressedStream from data and generate the output
  • All compressors now implement: <compressor_name>_to_data function. This decompresses the input with that specific compressor
  • Updated tests for the compressors to now work with the new _to_data methods
  • CompressorFrame added the decompress method, which calls for a given compressor is _to_data method
  • Compressor Enum now has the support via the decompress function to support frame decompression
  • CompressedStream new decompress method, chains decompress all the frames and returns a vector with data.

Fixed some bugs:

  • CompressorFrame sample numbers were not set
  • Due to the above, Size (in bytes) was being used as sample number and creating wrong outputs
  • Added FFT as a compressor for the command line

Copy link
Contributor

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@rukai rukai merged commit ca12e3c into main Oct 16, 2023
2 checks passed
@cjrolo cjrolo deleted the 20-10-Decompressing branch January 10, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants