-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constant benchmark #70
Conversation
joshuabvarghese
commented
Nov 12, 2023
- Added additional benchmarks for the "constant" compressor.
- Added benchmark functions for constant compression, decompression, optimization, compression vs. decompression, compression ratio, compression vs. data size, decompression vs. data size, memory usage, and compression vs. residuals.
- Provided documentation and comments explaining each benchmark function and its purpose.
- Utilized the Criterion crate for benchmarking and measuring performance.
When I run I believe this is because this PR is missing the This PR adds |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generating random inputs can contribute to noisy benchmarks, a way to avoid this while still having "random" data is to set a seed so that every run of the benchmark uses the same "random" data.
Something to investigate if you want to bring down the noise.
I'm not familiar enough with the functionality we are actually benchmarking to comment on how well we cover it.
But I've given all the generic benchmark advice I can, so, looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!