-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polynomial compressor #80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just noted a few things that can be simplified, go ahead and merge when ready.
Great review, thanks! I knew this would be a code that would need a good number of changes, and thanks for taking the time to review it. @joshuabvarghese your tests saved me a great time here, detected a lot of things that could had go south very fast! |
This PR lands the final compressor(s) for the BRRO compressor.
Included are some changes to error handling (There was a bug in the error function) and minor fixes on FFT and conversion functions.