Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polynomial compressor #80

Merged
merged 14 commits into from
Nov 24, 2023
Merged

Polynomial compressor #80

merged 14 commits into from
Nov 24, 2023

Conversation

cjrolo
Copy link
Collaborator

@cjrolo cjrolo commented Nov 23, 2023

This PR lands the final compressor(s) for the BRRO compressor.

  • Polynomial with two variants
    • IDW (Inverse Distance Weights) that should be better for more spiky signals
    • Linear/Catmull–Rom spline that should produce a continuous, easy to calculate curve over signals (vs a normal n-term polynomial)

Included are some changes to error handling (There was a bug in the error function) and minor fixes on FFT and conversion functions.

Copy link
Contributor

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noted a few things that can be simplified, go ahead and merge when ready.

@cjrolo
Copy link
Collaborator Author

cjrolo commented Nov 24, 2023

Great review, thanks! I knew this would be a code that would need a good number of changes, and thanks for taking the time to review it.

@joshuabvarghese your tests saved me a great time here, detected a lot of things that could had go south very fast!

@cjrolo cjrolo merged commit 0326550 into main Nov 24, 2023
2 checks passed
@cjrolo cjrolo deleted the polynomial-compressor branch November 24, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants