Error selection #81
Merged
Error selection #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cjrolo
commented
Nov 27, 2023
cjrolo
commented
- Made Error Function selection decent (via enum!)
- Fixed a BIG error on polynomial related to error bound compression
- Made Error function MAE default, then switched to MAPE. MAPE provides the most natural, explainable error function.
rukai
reviewed
Nov 27, 2023
rukai
reviewed
Nov 27, 2023
rukai
reviewed
Nov 27, 2023
| /// This function calculates the error between 2 arrays of f64. The results are from 0 to .. | ||
| /// Being 0, no error, 1 - 100% error and so on. | ||
| /// This uses the provided method to calculte it. | ||
| pub fn calculate_error_method(original: &[f64], generated: &[f64], method: ErrorMethod) -> f64 { |
There was a problem hiding this comment.
why use this over just method.error(original, generated)?
There was a problem hiding this comment.
This allows to force a specific method if needed. My guess will end as dead code. But I do see some advantages looking ahead. (Mostly for benchmarks).
rukai
approved these changes
Nov 27, 2023
joshuabvarghese
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.